Re: Read timeout POST and mp3.com

Jonathan Larmour writes:

>[snip most of pump.c:pumpReadFromClient() patch]
>> + commSetTimeout(p->c_fd, -1, NULL, NULL);
>
>and
>
>> No, probably it should contain
>>
>> commSetTimeout(p->s_fd, -1, NULL, NULL);
>>
>> in pumpServerCopyComplete().
>
>Surely neither of these are right? The problem reported was due to a large
>POST request where it is not even certain that the MP3 will have been
>transmitted to squid in the 15 minutes. Putting the update to s_fd line in
>pumpServerCopy() is the only way to keep the server side timeout updated.
>
>And the first patch above wouldn't have any effect since that's only the
>client side timeout - which will mostly have already been updated from about
>5 lines further up anyway for large requests.
>
>Or am I talking out my posterior?

No, you are correct. But as I realized I made two stupid mistakes
in a row, I was afraid to send out any more messages. I'll shut
up until I've actually tested something.

Duane W.
Received on Mon Feb 15 1999 - 15:12:58 MST