Re: [PATCH] -a command line option

On Sun, 14 Nov 2010 18:56:20 +0100, Kinkie <gkinkie_at_gmail.com> wrote:
> On Sun, Nov 14, 2010 at 11:53 AM, Amos Jeffries <squid3_at_treenet.co.nz>
> wrote:
>> The -a option was broken by some config updates early in the 3.x cycles
>> which reset SquidConfig prior to parsing but after opening the -a
>> provided
>> port.
>>
>> This patch preserves the documented -a behaviour of opening an HTTP
>> listener
>> port from the command line.
>> It also adds the double port opening for split-stack systems,
preserving
>> consistency with wildcard http_port entries in the config.
>>
>>
>> Overall, I'm not sure we actually need the -a option. Especially given
>> that
>> it appears to have been a few years before anyone noticed its being
>> broken.
>> What are peoples thoughts on deprecating it for removal in 3.3?
>
> +1 for deprecating.
> It'd be much more generic and interesting to allow specifying
> arbitrary config file lines (to be interpreted before loading
> squid.conf)
> e.g.
> squid -c 'http_port 3128' -f squid.conf

The problem -a hit was that all the config info gets erased when starting
the config parse. So that reconfigure works.
Any option like this would have to be implemented as equivalent to "-f
special.conf" where special.conf had that line then "include
/etc/squid.conf".

Amos
Received on Sun Nov 14 2010 - 20:45:30 MST