Re: FW: 3.1.0.15: 'make check' fails

Jenny Lee wrote:
> Difference between 3.1.0.14 and 3.1.0.15 test-suite/testheaders.sh
>
> 21,24d20
> < if [ "${f}" = "cf_gen_defines.h" -o "${f}" = "cf_parser.h" ]; then
> < echo " IGNORED!"
> < continue
> < fi
>
>
> Adding this completes 'make check' successfully.
>
> Jen
>

Yes, not testing it always has worked. :)

The real problem is that the file appears to contain things a .h should
not contain (static data). The QA test strangely passes sometimes.
Yours is the first compiler strict enough to bring the issue out, but I
expect others now that the QA is being done widely.

By our coding conventions in the rest of squid it should perhapse be a
.cci file or even .cc.

Amos

> ----------------------------------------
>> From: bodycare_5_at_live.com
>> To: squid-dev_at_squid-cache.org
>> Subject: 3.1.0.15: 'make check' fails
>> Date: Mon, 23 Nov 2009 23:59:08 +0000
>>
>>
>> 'make' and 'make install' alright. Operation alright. Only 'make check' bails out. 3.1.0.14 did not have this issue.
>>
>> Steps to produce: ./configure; make; make check
>>
>> RHEL 5.4 x86_64
>> gcc version 4.1.2 20080704 (Red Hat 4.1.2-46)
>>
>> Jen
>>
>>
>>
>> make check-TESTS
>> make[4]: Entering directory `/squid/squid-3.1.0.15/src'
>> /bin/sh ../test-suite/testheaders.sh "g++ -DHAVE_CONFIG_H -DDEFAULT_CONFIG_FILE=\"/usr/local/squid/etc/squid.conf\" -DDEFAULT_SQUID_DATA_DIR=\"/usr/local/squid/share\" -DDEFAULT_SQUID_CONFIG_DIR=\"/usr/local/squid/etc\" -I.. -I../include -I../src -I../include -I../lib -I../lib/libLtdl -I../src -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Werror -D_REENTRANT -g -O2" "." || exit 1
>> Testing ./AccessLogEntry.h ...OK.
>> Testing ./AsyncEngine.h ...OK.
>> Testing ./BodyPipe.h ...OK.
>> Testing ./CacheManager.h ...OK.
>> Testing ./cbdata.h ...OK.
>> Testing ./cf_gen_defines.h ...cc1plus: warnings being treated as errors
>> ././cf_gen_defines.h:5: warning: ‘defines’ defined but not used
>> make[4]: *** [testHeaders] Error 1
>> make[4]: Leaving directory `/squid/squid-3.1.0.15/src'
>> make[3]: *** [check-am] Error 2
>> make[3]: Leaving directory `/squid/squid-3.1.0.15/src'
>> make[2]: *** [check-recursive] Error 1
>> make[2]: Leaving directory `/squid/squid-3.1.0.15/src'
>> make[1]: *** [check] Error 2
>> make[1]: Leaving directory `/squid/squid-3.1.0.15/src'
>> make: *** [check-recursive] Error 1
>> _________________________________________________________________
>> Hotmail: Trusted email with Microsoft's powerful SPAM protection.
>> http://clk.atdmt.com/GBL/go/177141664/direct/01/
>> http://clk.atdmt.com/GBL/go/177141664/direct/01/
> _________________________________________________________________
> Windows 7: I wanted simpler, now it's simpler. I'm a rock star.
> http://www.microsoft.com/Windows/windows-7/default.aspx?h=myidea?ocid=PID24727::T:WLMTAGL:ON:WL:en-US:WWL_WIN_myidea:112009

-- 
Please be using
   Current Stable Squid 2.7.STABLE7 or 3.0.STABLE20
   Current Beta Squid 3.1.0.15