Re: [PATCH] Support ICY protocol (ICECast / ICEShout servers) in Squid-3

Amos Jeffries wrote:
> Since we have no central place where the headers are upgraded I've had
> to skip porting the upgrade_http0.9 hack in Squid-2 and go straight to
> accepting ICY protocol as an accepted response protocol and handling it.
>
> Somewhat primitive for now. It's limited to parsing and regenerating the
> status line correctly, and skipping the HTTP/1.0 version override on
> non-HTTP protocol replies.
>
> Since it is on port 80 I've temporarily left the HTTP/1.1 required
> header alterations happening. Some testing will be needed over the next
> few days to ensure that the client software treats unknown headers
> nicely. If needed overrides for those are easily done as well now.
>
> Amos
>

Now tested with VLC and WinAmp.

Looks like a success for the ICY changes. Sounds artifacts and
stuttering occurring regularly 1/sec without the patch. A seamless
stream of sound when it's added.

The patch as given breaks HTTP with an incorrectly inverted parse test.
And was omitting a bypass on the incomplete parsed reply case. Applied
after tweaks.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE7 or 3.0.STABLE20
   Current Beta Squid 3.1.0.14