Re: source code reorg & makefiles

Robert Collins wrote:
> I have one small request vis-a-vis the source code reorg.
>
> Please don't undo the non-recursive make support. I put a lot of effort
> into getting it where it was up to (even though that wasn't propogated
> across the entire code base). It makes a substantial difference to
> correctness, performance and ease of use of incremental builds.

Do you mean the DiskIO/* and fs/*/* stuff?

>
> Where the goal is to split out a Makefile, I suggest the use of an
> include to incorporate smaller files.
>

We are doing that.. (Common.am and TestHeaders.am etc)

> I can see a number of regressions in this to-date, which is why I'm
> asking that we not let it slide anymore.
>
> -Rob

Can you explain a bit more detail please? what are you seeing us do
wrong? we are not trying to remove anything at this point AFAIK.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE6 or 3.0.STABLE15
   Current Beta Squid 3.1.0.7