default cachemgr.cgi config updates

From: Amos Jeffries <squid3@dont-contact.us>
Date: Mon, 12 May 2008 13:36:20 +1200 (NZST)

<snip>
> As a side note, would it be possible to add something like
>
> @echo "$(INSTALL_DATA) $(srcdir)/cachemgr.conf
> $(DESTDIR)$(DEFAULT_CACHEMGR_CONFIG).default"; \
> $(INSTALL_DATA) $(srcdir)/cachemgr.conf
> $(DESTDIR)$(DEFAULT_CACHEMGR_CONFIG).default;
>
> to the install-data-local target? I have added this routine to the
> patch for 2346 while I was at it so users have a factory default
> to compare their configuration against after an update and the
> FreeBSD port/package is able to decide whether the user actually
> modified the .conf file and whether it must be kept on deinstallation.
>

I agree it would be a great addition to improve installation and package
maintenance.

Votes?

The change would be to always install the .default and conditionally add a
new .conf:

=== modified file 'tools/Makefile.am'
--- tools/Makefile.am 2008-05-11 13:01:38 +0000
+++ tools/Makefile.am 2008-05-12 01:27:33 +0000
@@ -45,6 +45,8 @@
 $(OBJS): $(top_srcdir)/include/version.h ../include/autoconf.h

 install-data-local:
+ @echo "$(INSTALL_DATA) $(srcdir)/cachemgr.conf
$(DESTDIR)$(DEFAULT_CACHEMGR_CONFIG).default"; \
+ $(INSTALL_DATA) $(srcdir)/cachemgr.conf
$(DESTDIR)$(DEFAULT_CACHEMGR_CONFIG).default; \
        @if test -f $(DESTDIR)$(DEFAULT_CACHEMGR_CONFIG) ; then \
                echo "$@ will not overwrite existing
$(DESTDIR)$(DEFAULT_CACHEMGR_CONFIG)" ; \
        else \
Received on Mon May 12 2008 - 01:36:25 MDT

This archive was generated by hypermail 2.2.0 : Tue May 13 2008 - 12:00:04 MDT