Re: Major pending change in 2.5 for multi-gigabyte file support

Hi Henrik,

At 04.38 26/03/2005, Henrik Nordstrom wrote:

>On Sat, 12 Mar 2005, Henrik Nordstrom wrote:
>
>>As some of you may have know the support in Squid for handling
>>multi-gigabyte files has long been non-existing at the best, both not at
>>all being able to handle files above 1.9 GB, bad interactions with the
>>cache (both on-disk and memory) in how largeish objects is processed and
>>the inability to write large log files on 32-bit platforms.
>
>>Unless someone objects I plan to incorporate these changes into Squid-2.5
>>shortly (14 days or so).
>
>Now committed to 2.5 as there was no objections, and I consider this a
>major flaw of Squid.

A little cleanup in client.c:

Index: src/client.c
===================================================================
RCS file: /squid/squid/src/client.c,v
retrieving revision 1.94.2.7
diff -u -p -r1.94.2.7 client.c
--- src/client.c 26 Mar 2005 02:50:51 -0000 1.94.2.7
+++ src/client.c 30 Mar 2005 08:01:37 -0000
@@ -379,7 +379,7 @@ main(int argc, char *argv[])
                 tmp->tm_hour, tmp->tm_min, tmp->tm_sec, i + 1,
                 elapsed_msec / 1000, elapsed_msec % 1000,
                 elapsed_msec ? (double) fsize / elapsed_msec * 1000 / 1024
: -1.
0,
- (long long) (fsize + 1023) / 1024);
+ (squid_off_t) (fsize + 1023) / 1024);
             if (i == 0 || elapsed_msec < ping_min)
                 ping_min = elapsed_msec;
             if (i == 0 || elapsed_msec > ping_max)

Windows don't like at all the long long type and fsize is defined as
squid_off_t type.

Regards

Guido

-
========================================================
Guido Serassio
Acme Consulting S.r.l. - Microsoft Certified Partner
Via Lucia Savarino, 1 10098 - Rivoli (TO) - ITALY
Tel. : +39.011.9530135 Fax. : +39.011.9781115
Email: guido.serassio@acmeconsulting.it
WWW: http://www.acmeconsulting.it/
Received on Wed Mar 30 2005 - 01:07:55 MST