Re: Major pending change in 2.5 for multi-gigabyte file support

Hi Henrik,

At 04.38 26/03/2005, Henrik Nordstrom wrote:

>On Sat, 12 Mar 2005, Henrik Nordstrom wrote:
>
>>As some of you may have know the support in Squid for handling
>>multi-gigabyte files has long been non-existing at the best, both not at
>>all being able to handle files above 1.9 GB, bad interactions with the
>>cache (both on-disk and memory) in how largeish objects is processed and
>>the inability to write large log files on 32-bit platforms.
>
>>Unless someone objects I plan to incorporate these changes into Squid-2.5
>>shortly (14 days or so).
>
>Now committed to 2.5 as there was no objections, and I consider this a
>major flaw of Squid.
>
>Most devel branches should be relatively safe from these changes even if
>this touched quite many files, and where cvsmerge does not figure it out
>automatically for you it shouldn't be too hard to resolve manually as most
>changes are relatively trivial in nature.

I have merged the Windows branch: only two minor little conflicts !!! :-)
Now I'm starting with the testing work.

I have found a typo error in configure.in:

Index: configure.in
===================================================================
RCS file: /squid/squid/configure.in,v
retrieving revision 1.251.2.85
diff -u -p -r1.251.2.85 configure.in
--- configure.in 26 Mar 2005 02:50:50 -0000 1.251.2.85
+++ configure.in 26 Mar 2005 19:04:11 -0000
@@ -759,7 +759,7 @@ AC_ARG_WITH(large-files,
  ])

  AC_ARG_ENABLE(large-cache-files,
-[ --enable-cache-large-files
+[ --enable-large-cache-files
                            Enable support for large cache files (>2GB).
                            WARNING: on-disk cache format is changed by
this option],
  [ if test "$enableval" = "yes" ; then

>You may want to audit your own developments for the same class of problems
>as adressed by this patch.

Working on awin32 source, the native Windows version of aufs, I have found
some little things that could be refined:

- Use FD_WRITE_METHOD/FD_READ_METHOD instead of write/read in all ufs,
diskd, aufs code, now there is a confusing mix.
- There is an old Windows and OS/2 file rename problem already fixed in 3.0
affecting diskd, coss, ufs and aufs:
http://www.squid-cache.org/mail-archive/squid-dev/200308/0028.html

If you think that this changes are fine, I will commit this.

Regards

Guido

-
========================================================
Guido Serassio
Acme Consulting S.r.l. - Microsoft Certified Partner
Via Lucia Savarino, 1 10098 - Rivoli (TO) - ITALY
Tel. : +39.011.9530135 Fax. : +39.011.9781115
Email: guido.serassio@acmeconsulting.it
WWW: http://www.acmeconsulting.it/
Received on Sat Mar 26 2005 - 13:16:19 MST